feat: Data pipelines unsubscribe modal #19334

tiina303 · 2023-12-14T17:05:36Z

Problem

https://github.com/PostHog/product-internal/pull/533

Added a button for testing it to apps management page, we should remove that before merging

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

How did you test this code?

=> clicked the button, which opened the modal

=> clicked disable on everything, which made unsubscribe button possible

then saw the lemonToast after hitting unsubscribe

posthog-bot · 2023-12-14T17:13:48Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2023-12-14T17:27:37Z

Size Change: 0 B

Total Size: 2 MB

ℹ️ View Unchanged

Filename	Size
`frontend/dist/toolbar.js`	2 MB

_{compressed-size-action}

posthog-bot · 2023-12-22T18:42:53Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

raquelmsmith · 2023-12-22T18:44:13Z

I hooked this up to the existing billing modal:

(was using group analytics to test this, but it's for Data Pipelines addon)

posthog-bot · 2023-12-22T22:46:40Z

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-01-01T07:31:19Z

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

tiina303 · 2024-01-02T12:04:13Z

Thanks @raquelmsmith the billing part looks good to me, though are we sure we want to call it 'product analytics + data stack'?

raquelmsmith · 2024-01-02T16:00:32Z

though are we sure we want to call it 'product analytics + data stack'?

Are you suggesting we just call it "Product analytics" and remove the "+data stack"? That makes sense, esp with data warehouse coming up. I'll make that change in billing.

frontend/src/scenes/billing/UnsubscribeSurveyModal.tsx

frontend/src/scenes/plugins/plugin/PluginImage.tsx

frontend/src/scenes/billing/ExportsUnsubscribeTable/exportsUnsubscribeTableLogic.tsx

posthog-bot · 2024-01-03T21:54:19Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…g/posthog into exports-unsubscribe-modal

tiina303 · 2024-01-04T12:44:35Z

frontend/snapshots/scenes-app-pipeline--pipeline-transformations-page--dark.png screenshots look broken now - the app name is missing for GeoIP app

…g/posthog into exports-unsubscribe-modal

Twixes

A couple rough edges in the UI that should be quick to address, but looks alright overall.
Might be useful to go through this flow in person on Monday, just to see it works smoothly @tiina303

Twixes · 2024-01-04T20:35:12Z

frontend/__snapshots__/scenes-app-pipeline--pipeline-transformations-page--light.png

Seems like there's only a small layout shift here, but a few notes on this UI:

Pretty weird that the activation CTA ("Create your first transformation") is visible even if there already are transformations

Item icons should always be the first column, and icon columns shouldn't have a name – in this case "App" is the icon column

The "Order" column should have width: 0 so that it takes up as little space as possible

Might be good as a separate PR

I don't think this UI was touched as part of this PR? But not sure why this snapshot would have changed... either way I'll leave you two to update this in a separate PR.

Twixes · 2024-01-04T20:49:44Z

...d/__snapshots__/scenes-other-billing-v2--billing-unsubscribe-modal-data-pipelines--light.png

"Team" is our internal naming, UI should only ever say "Project".
Also gonna repeat the point with the icon looking weird if it's not the first column. In this case I think the project can be on the right – what do you think?

…g/posthog into exports-unsubscribe-modal

posthog-bot · 2024-01-04T21:28:34Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2024-01-04T21:36:56Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

* feat: Exports unsubscribe modal * Changes * Fix query * Make modal work for plugin configs * plugins part should work now * wip batch exports * batch exports finished + modal access listeners * fix name and description to be writable * rename and move table to main billing unsub modal * add text and disabled reason * improve disabled state * Update UI snapshots for `chromium` (1) * move into billing * use correct product name * stories * fix * make images smaller * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * Update frontend/src/scenes/plugins/plugin/PluginImage.tsx Co-authored-by: Bianca Yang <[email protected]> * remove old logic * fix * fix * fix overlap * Update UI snapshots for `chromium` (1) * delete snapshots so they are regenerated * Update UI snapshots for `chromium` (1) * fix test * unfix? * project not team * reorder columns * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) --------- Co-authored-by: Michael Matloka <[email protected]> Co-authored-by: Raquel Smith <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Bianca Yang <[email protected]>

tiina303 requested review from Twixes, raquelmsmith and a team December 14, 2023 17:08

tiina303 force-pushed the exports-unsubscribe-modal branch from 56297fe to a90c02f Compare December 15, 2023 11:20

tiina303 marked this pull request as ready for review December 15, 2023 11:20

tiina303 force-pushed the exports-unsubscribe-modal branch from a90c02f to 1c192e5 Compare December 15, 2023 11:20

raquelmsmith requested a review from xrdt December 22, 2023 22:39

raquelmsmith self-assigned this Dec 22, 2023

posthog-bot added the stale label Jan 1, 2024

tiina303 mentioned this pull request Jan 2, 2024

feat: Billing integration with data pipelines unsubscribe modal #19336

Closed

tiina303 removed the stale label Jan 2, 2024

xrdt reviewed Jan 2, 2024

View reviewed changes

frontend/src/scenes/billing/UnsubscribeSurveyModal.tsx Outdated Show resolved Hide resolved

xrdt reviewed Jan 2, 2024

View reviewed changes

frontend/src/scenes/plugins/plugin/PluginImage.tsx Outdated Show resolved Hide resolved

xrdt reviewed Jan 2, 2024

View reviewed changes

frontend/src/scenes/billing/ExportsUnsubscribeTable/exportsUnsubscribeTableLogic.tsx Show resolved Hide resolved

raquelmsmith mentioned this pull request Jan 3, 2024

Sprint - Jan 8 to Jan 19 #19572

Closed

tiina303 and others added 7 commits January 3, 2024 13:26

feat: Exports unsubscribe modal

c619609

Changes

96d480f

Fix query

3281075

Make modal work for plugin configs

244fbcd

plugins part should work now

b0eb00c

wip batch exports

afc95de

batch exports finished + modal access listeners

300fa9f

raquelmsmith and others added 4 commits January 3, 2024 13:33

fix

9d3e9b9

fix

19e8168

fix overlap

d840c04

Update UI snapshots for chromium (1)

74a07da

raquelmsmith requested a review from xrdt January 3, 2024 23:00

raquelmsmith and others added 3 commits January 3, 2024 15:15

delete snapshots so they are regenerated

86ad60e

Merge branch 'exports-unsubscribe-modal' of https://github.com/PostHo…

1be1eb6

…g/posthog into exports-unsubscribe-modal

Update UI snapshots for chromium (1)

2879415

xrdt approved these changes Jan 4, 2024

View reviewed changes

raquelmsmith added 2 commits January 4, 2024 08:30

fix test

0da4867

Merge branch 'exports-unsubscribe-modal' of https://github.com/PostHo…

24fb092

…g/posthog into exports-unsubscribe-modal

raquelmsmith approved these changes Jan 4, 2024

View reviewed changes

raquelmsmith enabled auto-merge (squash) January 4, 2024 16:35

Twixes approved these changes Jan 4, 2024

View reviewed changes

unfix?

ec96787

raquelmsmith disabled auto-merge January 4, 2024 21:17

raquelmsmith and others added 5 commits January 4, 2024 13:19

project not team

b5821a3

reorder columns

070814b

Merge branch 'master' into exports-unsubscribe-modal

fb37011

Merge branch 'exports-unsubscribe-modal' of https://github.com/PostHo…

3ab1e56

…g/posthog into exports-unsubscribe-modal

Update UI snapshots for chromium (1)

75b6984

Update UI snapshots for chromium (1)

e0767df

raquelmsmith merged commit 0c96017 into master Jan 5, 2024
99 checks passed

raquelmsmith deleted the exports-unsubscribe-modal branch January 5, 2024 19:20

raquelmsmith mentioned this pull request Jan 17, 2024

Sprint - Jan 22 to Feb 2, 2024 #19804

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Data pipelines unsubscribe modal #19334

feat: Data pipelines unsubscribe modal #19334

tiina303 commented Dec 14, 2023 •

edited

Loading

posthog-bot commented Dec 14, 2023

github-actions bot commented Dec 14, 2023 •

edited

Loading

posthog-bot commented Dec 22, 2023

raquelmsmith commented Dec 22, 2023 •

edited

Loading

posthog-bot commented Dec 22, 2023

posthog-bot commented Jan 1, 2024

tiina303 commented Jan 2, 2024

raquelmsmith commented Jan 2, 2024

posthog-bot commented Jan 3, 2024

tiina303 commented Jan 4, 2024

Twixes left a comment

Twixes Jan 4, 2024

raquelmsmith Jan 4, 2024

Twixes Jan 4, 2024

posthog-bot commented Jan 4, 2024

posthog-bot commented Jan 4, 2024

feat: Data pipelines unsubscribe modal #19334

feat: Data pipelines unsubscribe modal #19334

Conversation

tiina303 commented Dec 14, 2023 • edited Loading

Problem

Changes

How did you test this code?

posthog-bot commented Dec 14, 2023

📸 UI snapshots have been updated

github-actions bot commented Dec 14, 2023 • edited Loading

posthog-bot commented Dec 22, 2023

📸 UI snapshots have been updated

raquelmsmith commented Dec 22, 2023 • edited Loading

posthog-bot commented Dec 22, 2023

📸 UI snapshots have been updated

posthog-bot commented Jan 1, 2024

tiina303 commented Jan 2, 2024

raquelmsmith commented Jan 2, 2024

posthog-bot commented Jan 3, 2024

📸 UI snapshots have been updated

tiina303 commented Jan 4, 2024

Twixes left a comment

Choose a reason for hiding this comment

Twixes Jan 4, 2024

Choose a reason for hiding this comment

raquelmsmith Jan 4, 2024

Choose a reason for hiding this comment

Twixes Jan 4, 2024

Choose a reason for hiding this comment

posthog-bot commented Jan 4, 2024

📸 UI snapshots have been updated

posthog-bot commented Jan 4, 2024

📸 UI snapshots have been updated

tiina303 commented Dec 14, 2023 •

edited

Loading

github-actions bot commented Dec 14, 2023 •

edited

Loading

raquelmsmith commented Dec 22, 2023 •

edited

Loading